Setting LED's keeps crashing my T2

[pablosscripts]

The following keeps freezing up my T2 after just a few seconds of play. Any ideas what I've done wrong?

Code: Select all



main {
    if(rappelling_flag || AutoReloadAction) {
        ColorLED('W');
    }
    if(!rappelling_flag && !AutoReloadAction) {
        ColorLED('B');
    }

}

void ColorLED(char Color) {
    fix32 Color1, Color2, Color3, Color4;
   
    if(Color == 'B'){Color1 = 100.0;    Color2 = 0.00;    Color3 = 0.00;    Color4 = 0.00;}
    if(Color == 'R'){Color1 = 0.00;    Color2 = 100.0;    Color3 = 0.00;    Color4 = 0.00;}
    if(Color == 'G'){Color1 = 0.00;    Color2 = 0.00;    Color3 = 100.0;    Color4 = 0.00;}
    if(Color == 'P'){Color1 = 0.00;    Color2 = 0.00;    Color3 = 0.00;    Color4 = 100.0;}
    if(Color == 'C'){Color1 = 100.0;    Color2 = 0.00;    Color3 = 100.0;    Color4 = 0.00;}
    if(Color == 'A'){Color1 = 0.00;    Color2 = 100.0;    Color3 = 100.0;    Color4 = 0.00;}
    if(Color == 'W'){Color1 = 100.0;    Color2 = 100.0;    Color3 = 100.0;    Color4 = 100.0;}
   
    led_set(LED_1, Color1, 0);
    led_set(LED_2, Color2, 0);
    led_set(LED_3, Color3, 0);
    led_set(LED_4, Color4, 0);
   
    return;
}

[Scachi]

I think your are flooding the usb with your second statement, always sending ColorLED('B');
Maybe you should at something like a "toggle" variable that remembers the last color state and only call the ColorLED function if the value of the toggle variable has changes to only send the color once then ?

[pablosscripts]

I think your are flooding the usb with your second statement, always sending ColorLED('B');
Maybe you should at something like a "toggle" variable that remembers the last color state and only call the ColorLED function if the value of the toggle variable has changes to only send the color once then ?

Ah yes you're right ok I'll rework the code, thank you!

[pablosscripts]

On your suggestion I've rewritten it, hopefully this works. I'll have to test it tonight when I get home:

Code: Select all

    int led_change_flag = 0;
   
    if(rappelling_flag || AutoReloadAction) {
        ColorLED('W');
        led_change_flag = 0;
    }

    if((!rappelling_flag && !AutoReloadAction) && led_change_flag == 0) {
        ColorLED('B');
        led_change_flag = 1;
    }

[pablosscripts]

Ok the code above doesn't work:( It keeps freezing. Can anyone see what I've done wrong?

[J2Kbr]

the best solution for this is call ColorLED in the same block you change the variables rappelling_flag and AutoReloadAction;

[pablosscripts]

the best solution for this is call ColorLED in the same block you change the variables rappelling_flag and AutoReloadAction;

The problem isn't with setting the LED's, it's reverting it back to the original colour. Setting it is never a problem, it's the revert that freezes my T2.

[J2Kbr]

please post your full code (or pm me), so I can try find a good way to set/reset the LED color using ColorLED .

[pablosscripts]

Thanks! I've uploaded it to online resources. See lines 896, 936, or 1240 (original attempt at this, commented out).

[J2Kbr]

I changed the LED logic logic a little bit:

Code: Select all

if((rappelling_flag || AutoReloadAction) && !led_change_flag) {
        ColorLED('W');
        led_change_flag = 1;
    } else if((!rappelling_flag && !AutoReloadAction) && led_change_flag) {
        ColorLED('B');
        led_change_flag = 0;
    }